refactor: enforce final and make extendable classes abstract#35
Merged
lindyhopchris merged 2 commits intonextfrom May 8, 2026
Merged
refactor: enforce final and make extendable classes abstract#35lindyhopchris merged 2 commits intonextfrom
lindyhopchris merged 2 commits intonextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces
finalclasses. This means that all classes (e.g. bus dispatchers) that are intended to be extended (so they can implement the module interface e.g. the specific command bus interface) are nowabstract.This should just work with existing implementations. The only potential impact would be the exception classes, which are now
final- instead there are exception interfaces that should be caught.